-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make_cfg refactoring in examples/tutorial/ #1924
Conversation
Hi @NakuraMino! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Motivation and Context
Refactoring
make_cfg
to usehabitat_sim.utils.settings.make_cfg
.How Has This Been Tested
Running
python examples/nb_python/*.py
for the files that have been modified and checked that all the outputs are equivalent.Colab files can be tested by inserting the following code block at the very start:
Install habitat_lab:
and then follow the instructions mentioned in #1818. Restart runtime, and then run the remaining cells (except for the first one).
I checked the visual outputs to the colab files are identical to the the colab outputs before the changes.
Types of changes
Checklist