--fix an error - shouldn't normalize the cross product.

facebookresearch · Feb 1, 2024 · afae3b5 · afae3b5
1 parent e4238af
commit afae3b5
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/esp/core/Utility.h b/src/esp/core/Utility.h
@@ -63,9 +63,8 @@ Magnum::Math::Quaternion<T> quatRotFromTwoVectors(
     return Magnum::Math::Quaternion<T>(rotAxisVec, 0).normalized();
   }
   const auto halfVec = (fromNorm + toNorm).normalized();
-  return Magnum::Math::Quaternion<T>(
-             Magnum::Math::cross(fromNorm, halfVec).normalized(),
-             Magnum::Math::dot(fromNorm, halfVec))
+  return Magnum::Math::Quaternion<T>(Magnum::Math::cross(fromNorm, halfVec),
+                                     Magnum::Math::dot(fromNorm, halfVec))
       .normalized();
 }  // quatRotFromTwoVectors