Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Add missing sim type hints. #1989

Merged
merged 4 commits into from
Jun 21, 2024
Merged

HITL - Add missing sim type hints. #1989

merged 4 commits into from
Jun 21, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Jun 20, 2024 •
edited

Motivation and Context

This small changeset adds missing habitat_sim type hints to HITL.

The type hints were acquired using this branch.

How Has This Been Tested

N/A

Types of changes

  • [Refactoring]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested a review from aclegg3 June 20, 2024 16:39
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 20, 2024
@0mdc 0mdc merged commit 7982190 into main Jun 21, 2024
4 checks passed
@0mdc 0mdc deleted the 0mdc/hitl_sim_types branch June 21, 2024 18:36
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@0mdc @dannymcy
HITL - Add missing sim type hints. (facebookresearch#1989)
33ad9ce 
* Add sim types to world.py.

* Add type hints to gui_placement_helper.

* Add type hints to hablab_utils.py.

* Add mouse ray type.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
HITL - Add missing sim type hints. (facebookresearch#1989)
169ee2e 
* Add sim types to world.py.

* Add type hints to gui_placement_helper.

* Add type hints to hablab_utils.py.

* Add mouse ray type.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc @dannymcy
HITL - Add missing sim type hints. (facebookresearch#1989)
7a9136b 
* Add sim types to world.py.

* Add type hints to gui_placement_helper.

* Add type hints to hablab_utils.py.

* Add mouse ray type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0mdc @aclegg3 @facebook-github-bot