Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] - update for Magnum breaking API change #1356

Merged
merged 3 commits into from
May 24, 2023
Merged

[refactor] - update for Magnum breaking API change #1356

merged 3 commits into from
May 24, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 19, 2023 •
edited
Loading

Motivation and Context

Accommodates for facebookresearch/habitat-sim#2114

Types of changes

  • [Refactoring] Large changes to the code that improve its functionality or performance

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@aclegg3 aclegg3 requested a review from mosra May 19, 2023 16:06
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 19, 2023
@aclegg3 aclegg3 mentioned this pull request May 22, 2023
Merged
@mosra mosra merged commit 91ab2b8 into main May 24, 2023
@mosra mosra deleted the refactor-magnum-update branch May 24, 2023 09:18
@0mdc 0mdc mentioned this pull request May 27, 2023
Merged
yvsriram pushed a commit that referenced this pull request Jun 1, 2023
@aclegg3 @yvsriram
[refactor] - update for Magnum breaking API change (#1356)
8106b47 
* minor refactor to support Magnum breaking change
yvsriram added a commit that referenced this pull request Jun 4, 2023
@yvsriram @aclegg3
Ovmm: cherry pick sim breaking change, option for ibl (#1395)
902b545 
* [refactor] - update for Magnum breaking API change (#1356)

* minor refactor to support Magnum breaking change

* add option for enabling ibl

---------

Co-authored-by: Alexander Clegg <[email protected]>
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@aclegg3
[refactor] - update for Magnum breaking API change (facebookresearch#…
ee1b3a3 
…1356)

* minor refactor to support Magnum breaking change
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
@aclegg3
[refactor] - update for Magnum breaking API change (facebookresearch#…
1585a8d 
…1356)

* minor refactor to support Magnum breaking change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosra mosra mosra approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @mosra @facebook-github-bot