Skip to content

Commit

Permalink
Fix unsafe fallthrough at fbcode/fbpcf/scheduler/gate_keeper/BatchCom…
Browse files Browse the repository at this point in the history
…positeGate.h:63 (#533)

Summary:
Pull Request resolved: #533

details in T179856888

**context**

LLVM has detected an implicit fallthrough near fbcode/fbpcf/scheduler/gate_keeper/BatchCompositeGate.h:63. Implicit fallthroughs have a very high bug rate, so we are making them a compiler error by default.

Reviewed By: ztlbells

Differential Revision: D54025656

fbshipit-source-id: 4a2c501c17063b2bb0a91489df169544b59ab75f
  • Loading branch information
Zhenhuan Zhang authored and facebook-github-bot committed Feb 21, 2024
1 parent 3e809b2 commit 76ee6a9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fbpcf/scheduler/gate_keeper/BatchCompositeGate.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ class BatchCompositeGate final : public ICompositeGate {
engine.computeBatchFreeAND(
leftValues, wireKeeper_.getBatchBooleanValue(rights_[i])));
}
break;
}

case GateType::NonFreeAnd: {
Expand Down

0 comments on commit 76ee6a9

Please sign in to comment.