Skip to content

Commit

Permalink
Remove unused variables in fboss/agent/state/Interface.cpp
Browse files Browse the repository at this point in the history
Summary:
LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: peygar

Differential Revision: D55099975

fbshipit-source-id: c4c4d45c215f0bf401a9795121fd75bca9bad6d2
  • Loading branch information
r-barnes authored and facebook-github-bot committed Mar 20, 2024
1 parent 4772c0f commit 50bd551
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fbpcf/frontend/test/benchmarks/FrontendBenchmark.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

namespace fbpcf::frontend {

const bool unsafe = true;
// const bool unsafe = true;
const uint32_t batchSize = 1000;

template <class Game0, class Game1>
Expand Down

0 comments on commit 50bd551

Please sign in to comment.