Fixed pkg_resource deprecation warning
#5484
Open
+12
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
ruck94301
reviewed
Oct 20, 2025
There was a problem hiding this comment.
The change to .gitignore are not germane to replacing pkg_resource.resource_filename, right?
Should it be removed from the PR?
| from detectron2.checkpoint import DetectionCheckpointer | ||
| from detectron2.config import CfgNode, LazyConfig, get_cfg, instantiate | ||
| from detectron2.modeling import build_model | ||
| from importlib import resources as importlib_resources |
There was a problem hiding this comment.
detectron2 is still advertising compatibility w/ Python 3.7.
importlib.resources is introduced in Python 3.9.
So I think this breaks some compatibility. Easy to fix, but needs attention.
| skip_glob=*/__init__.py,**/configs/**,**/tests/config/** | ||
| known_myself=detectron2 | ||
| known_third_party=fvcore,matplotlib,cv2,torch,torchvision,PIL,pycocotools,yacs,termcolor,cityscapesscripts,tabulate,tqdm,scipy,lvis,psutil,pkg_resources,caffe2,onnx,panopticapi,black,isort,av,iopath,omegaconf,hydra,yaml,pydoc,submitit,cloudpickle,packaging,timm,pandas,fairscale,pytorch3d,pytorch_lightning | ||
| known_third_party=fvcore,matplotlib,cv2,torch,torchvision,PIL,pycocotools,yacs,termcolor,cityscapesscripts,tabulate,tqdm,scipy,lvis,psutil,importlib_resources,caffe2,onnx,panopticapi,black,isort,av,iopath,omegaconf,hydra,yaml,pydoc,submitit,cloudpickle,packaging,timm,pandas,fairscale,pytorch3d,pytorch_lightning |
There was a problem hiding this comment.
Yes, remove pkg_resources. But I'm thinking that adding importlib_resources here only makes sense if you might possibly import it (and importing importlib.resources as importlib_resources doesn't count, right?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have observed a deprecation warning message for using
pkg_resources. This PR migrates frompkg_resourcestoimportlib.resourcesaccording to the migration guide: https://importlib-resources.readthedocs.io/en/latest/migration.html#pkg-resources-resource-filename.The
pkg_resourcesis only used in one location for one function.This also adds some environment files and directories to the git ignore list.