Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegated Private Matching for Compute (DPMC) #116

Closed
wants to merge 23 commits into from

Conversation

jimouris
Copy link
Collaborator

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

  1. Extending multi-key Private-ID to Delegated Private Matching for Compute (DPMC) which supports multiple partners with the help of a helper/delegate server.
  • Company has a csv with identifiers (e.g., etc/example/dpmc/Ex0_company.csv).
  • Partner has a csv with identifiers (e.g., etc/example/dpmc/Ex0_partner_1.csv) and a csv with features (e.g., etc/example/dpmc/Ex0_partner_1_features.csv).
  1. Extending DPMC to Delegated Private Matching for Compute with Secure Shuffling (DSPMC) which supports multiple partners with the help of two helpers/delegate servers.
  • Company has a csv with identifiers (e.g., etc/example/dspmc/Ex0_company.csv).
  • Partner has a csv with identifiers (e.g., etc/example/dspmc/Ex0_partner_1.csv) and a csv with features (e.g., etc/example/dspmc/Ex0_partner_1_features.csv).

How Has This Been Tested (if it applies)

Tests are located in etc/example/dpmc and etc/example/dspmc.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 19, 2023
@facebook-github-bot
Copy link
Contributor

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@shubho
Copy link
Contributor

shubho commented Oct 28, 2023

Can check you why we get

unresolved import `aws_sdk_s3::error::NoSuchUpload`

consider importing one of these items instead
private_id_protocols/private_id/common/src/s3_path.rs

in lines 13 to 17?

@jimouris
Copy link
Collaborator Author

@shubho I updated the AWS crates, it should be fine now. Can you try again?

@facebook-github-bot
Copy link
Contributor

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@shubho
Copy link
Contributor

shubho commented Oct 28, 2023

Failed to resolve

failed to resolve: use of undeclared crate or module `fernet`

in ‎
private_id_protocols‎/private_id‎/protocol‎/src‎/dpmc‎/helper.rs‎
private_id_protocols‎/private_id‎/protocol‎/src‎/dpmc‎/partner.rs‎

@shubho
Copy link
Contributor

shubho commented Oct 28, 2023

can't find crate for `base64`

in
private_id_protocols‎/private_id‎/protocol‎/src‎/dpmc‎/helper.rs‎
private_id_protocols‎/private_id‎/protocol‎/src‎/dpmc‎/partner.rs‎

@jimouris
Copy link
Collaborator Author

@shubho I updated these two crates to their latest versions. Their API had changed a bit. Let's see if that was the issue.

@facebook-github-bot
Copy link
Contributor

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@shubho
Copy link
Contributor

shubho commented Oct 29, 2023

I still get the same errors - the fernet errors are in
line 113 and 174 private_id/protocol/src/dpmc/helper.rs
line 182 and 285 private_id/protocol/src/dpmc/partner.rs

And the base64 errors are in
line 4 in private_id/protocol/src/dpmc/helper.rs
line 4 in private_id/protocol/src/dpmc/partner.rs

@jimouris
Copy link
Collaborator Author

I made some changes, can you check again? What is the command that generates these errors? I can't replicate them locally.

@facebook-github-bot
Copy link
Contributor

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@shubho
Copy link
Contributor

shubho commented Oct 29, 2023

Same problem when you do use base64 or use fernet they aren't resolving - do you need to do extern? The lines where you do use base64 (or fernet) - I get unresolved import base64 etc

@jimouris
Copy link
Collaborator Author

That's odd, both dependencies are in Cargo.toml and I have use statements. Based on this use should be sufficient. I had it with extern crate .. before and it was also causing the error.

Is there a way to find the specific Rust version and the command that generates the error?

@shubho
Copy link
Contributor

shubho commented Oct 29, 2023

I think the problem is the base64 and fernet packages don't exist in our internal build system - this will take longer than expected I think

@prasadbuddhavarapu
Copy link

Updated fernet, and base64 should be 0.13. We should do another pull to update.

@facebook-github-bot
Copy link
Contributor

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@prasadbuddhavarapu merged this pull request in 26b08dd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants