-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing package bug breaking liveUpdate tasks over https #728
Conversation
Codecov Report
@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 64.27% 64.28% +0.01%
==========================================
Files 107 107
Lines 9200 9200
==========================================
+ Hits 5913 5914 +1
+ Misses 3287 3286 -1
Continue to review full report at Codecov.
|
@pringshia any idea why the mephisto-task-latest check is failing on this pr? I know pre-commit black is failing due to a circle error only recently resolved, but don't see what's wrong otherwise here. Will still merge as the referenced files in this PR have the new 2.0.1 version in the |
@JackUrb I'm not sure why the commit at And that commit has the older version of the package defined:
Update: It seems the I'll investigate a fix tomorrow. |
@JackUrb - Only the remote procedure and static_react_task's packages were updated to 1.0.1 in this PR. What about parlai chat? |
Summary
Just changing
wws
=>wss
as it should have been. Unsure how I missed this in the test plan. Includes updates to prepare Mephisto for a 1.0.1 release and tag.Implementation
Mostly updating our packages to now refer to 2.0.1 and 1.0.1, other than a single character change.
Testing
Ran the task in sandbox that was having issue before, it no longer does with 2.0.1
Thanks @jxmsML for surfacing the issue.