-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark load #49
Benchmark load #49
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 43 43
Lines 3899 3899
=======================================
Hits 3530 3530
Misses 369 369 ☔ View full report in Codecov by Sentry. |
This looks pretty useful to me. Are you ready to land it? |
8aefe9e
to
ee928eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this benchmark tool. It would help us to optimize the code for higher performance.
@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@briancoutinho merged this pull request in 4ac4385. |
What does this PR do?
Adds benchmarks for trace load and parsing #48
Before submitting
not sure?
Benchmark results
Run using
Before Anupam's PR #48 optimizing out the get_memory_size we see the load/parsing times were
After his PR we now see the time reduced for loading