Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark load #49

Closed
wants to merge 4 commits into from
Closed

Benchmark load #49

wants to merge 4 commits into from

Conversation

briancoutinho
Copy link
Contributor

What does this PR do?

Adds benchmarks for trace load and parsing #48

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you update the changelog?
    • N/A
      not sure?

Benchmark results

Run using

python3 benchmarks/trace_load_benchmark.py -p 10 -l 1

Before Anupam's PR #48 optimizing out the get_memory_size we see the load/parsing times were

parse[tests/data/vision_transformer]: Mean +- std dev: 12.4 sec +- 0.5 sec
parse[tests/data/inference_single_rank]: Mean +- std dev: 15.0 sec +- 0.5 sec

After his PR we now see the time reduced for loading

parse[tests/data/vision_transformer]: Mean +- std dev: 6.24 sec +- 0.19 sec
parse[tests/data/inference_single_rank]: Mean +- std dev: 9.25 sec +- 0.19 sec

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (ec3abf1) to head (ee928eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files          43       43           
  Lines        3899     3899           
=======================================
  Hits         3530     3530           
  Misses        369      369           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louisfeng
Copy link

This looks pretty useful to me. Are you ready to land it?

@louisfeng louisfeng self-requested a review July 18, 2023 17:34
@briancoutinho briancoutinho marked this pull request as ready for review February 29, 2024 08:06
@briancoutinho briancoutinho self-assigned this Mar 4, 2024
Copy link
Contributor

@fengxizhou fengxizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this benchmark tool. It would help us to optimize the code for higher performance.

@facebook-github-bot
Copy link
Contributor

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@briancoutinho merged this pull request in 4ac4385.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants