Fix SOFA Import Degree Handling #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current SOFA import code results in a right shift of most sources by about 6 degrees and some holes/instability, since the SOFA azimuth in degrees is wrapped by 2*pi as if it were in rad:
I removed the corresponding lines. Since they are purely re-assigning, there is no impact on the surrounding code.
While you look at the code, please also evaluate whether the exact same lines are needed for the switch case above.
sph2cartseems to consist of some simple statements with sines/cosines which should work regardless of angle range. But I don't have an FRL_HRTF file to test that.