Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: restore build size bot #92

Merged
merged 4 commits into from
Mar 3, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 3, 2021

After investigating a security issue using pull_request_target, we decided to finally keep build size bot but using pull_request.

It solves the security issue, but this means the build size bot won't be able to post a PR comment if the PR is from a fork.

See preactjs/compressed-size-action#54
See https://securitylab.github.com/research/github-actions-preventing-pwn-requests

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2021
@github-actions
Copy link

github-actions bot commented Mar 3, 2021

Size Change: 0 B

Total Size: 528 kB

ℹ️ View Unchanged
Filename Size Change
./packages/core/dist/css/default-dark/default-dark-rtl.css 76.6 kB 0 B
./packages/core/dist/css/default-dark/default-dark-rtl.min.css 53.3 kB 0 B
./packages/core/dist/css/default-dark/default-dark.css 76.6 kB 0 B
./packages/core/dist/css/default-dark/default-dark.min.css 53.3 kB 0 B
./packages/core/dist/css/default/default-rtl.css 75.8 kB 0 B
./packages/core/dist/css/default/default-rtl.min.css 52.8 kB 0 B
./packages/core/dist/css/default/default.css 75.7 kB 0 B
./packages/core/dist/css/default/default.min.css 52.8 kB 0 B
./packages/core/dist/js/alerts.js 409 B 0 B
./packages/core/dist/js/alerts.min.js 409 B 0 B
./packages/core/dist/js/button-groups.js 267 B 0 B
./packages/core/dist/js/button-groups.min.js 267 B 0 B
./packages/core/dist/js/dropdowns.js 1.01 kB 0 B
./packages/core/dist/js/dropdowns.min.js 1.01 kB 0 B
./packages/core/dist/js/menu.js 1.74 kB 0 B
./packages/core/dist/js/menu.min.js 1.74 kB 0 B
./packages/core/dist/js/navbar.js 926 B 0 B
./packages/core/dist/js/navbar.min.js 926 B 0 B
./packages/core/dist/js/pills.js 270 B 0 B
./packages/core/dist/js/pills.min.js 270 B 0 B
./packages/core/dist/js/radio-behavior.js 705 B 0 B
./packages/core/dist/js/radio-behavior.min.js 705 B 0 B
./packages/core/dist/js/tabs.js 267 B 0 B
./packages/core/dist/js/tabs.min.js 267 B 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Mar 3, 2021

Deploy preview for infima ready!

Built with commit 8db948a

https://deploy-preview-92--infima.netlify.app

@slorber slorber merged commit 4522d02 into master Mar 3, 2021
@yangshun yangshun deleted the slorber/update-build-size-bot branch March 3, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants