Remove unnecessary accumulator initialization with loop peeling #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a loop peeling pass that automatically translates a matmul loop into a peeled version to avoid the zero out of the accumulator.
So a normal K-loop is like
With loop peeling we get
The pass is placed after the software pipeliner to avoid messing up with it.
To ensure the correct behavior when the loop is not executed at all,
tl.assume
is needed on the source level.The peeling pass is only triggered for constant bounded loops or with
tl.assume
.3% win was seen on some shapes.