Roll back to nightly-2019-07-08 for release to LIBRA

.travis.yml

@@ -1,7 +1,7 @@
 os: osx
 language: rust
 rust:
-- nightly-2019-08-12
+- nightly-2019-07-08
 
 before_install:
 - if [ ${TRAVIS_OS_NAME} == "osx" ]; then curl -L https://github.com/mozilla/grcov/releases/download/v0.4.3/grcov-osx-x86_64.tar.bz2 | tar jxf -; fi

checker/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 
 name = "mirai"
-version = "1.0.0"
+version = "1.0.1"
 authors = ["Herman Venter <[email protected]>"]
 description = "A static analysis tool for Rust, based on Abstract Interpretation of MIR"
 repository = "https://github.com/facebookexperimental/MIRAI"

checker/src/callbacks.rs

@@ -15,7 +15,6 @@ use log::{info, warn};
 use log_derive::{logfn, logfn_inputs};
 use rustc::hir::def_id::DefId;
 use rustc::ty::TyCtxt;
-use rustc_driver::Compilation;
 use rustc_interface::interface;
 use std::collections::{HashMap, HashSet};
 use std::fmt::{Debug, Formatter, Result};
@@ -90,24 +89,19 @@ impl rustc_driver::Callbacks for MiraiCallbacks {
     /// interpretation of all of the functions that will end up in the compiler output.
     /// If this method returns false, the compilation will stop.
     #[logfn(TRACE)]
-    fn after_analysis(&mut self, compiler: &interface::Compiler) -> Compilation {
+    fn after_analysis(&mut self, compiler: &interface::Compiler) -> bool {
         compiler.session().abort_if_errors();
         if self.output_directory.to_str().unwrap().contains("/build/") {
             // No need to analyze a build script, but do generate code.
-            return Compilation::Continue;
+            return true;
         }
         compiler
             .global_ctxt()
             .unwrap()
             .peek_mut()
             .enter(|tcx| self.analyze_with_mirai(compiler, &tcx));
-        if self.test_run {
-            // We avoid code gen for test cases because LLVM is not used in a thread safe manner.
-            Compilation::Stop
-        } else {
-            // Although MIRAI is only a checker, cargo still needs code generation to work.
-            Compilation::Continue
-        }
+        !self.test_run // Although MIRAI is only a checker, cargo still needs code generation to work.
+                       // We avoid code gen for test cases because LLVM is not used in a thread safe manner.
     }
 }
 

checker/src/summaries.rs

@@ -639,7 +639,7 @@ impl<'a, 'tcx: 'a> PersistentSummaryCache<'a, 'tcx> {
             self.cache.entry(def_id).or_insert_with(|| {
                 let summary = Self::get_persistent_summary_for_db(db, &persistent_key);
                 if !def_id.is_local() && summary.is_none() {
-                    info!(
+                    warn!(
                         "Summary store has no entry for {}{}",
                         persistent_key, arg_types_key
                     );