Skip to content
This repository has been archived by the owner on Nov 28, 2018. It is now read-only.

Allow withLabel to be a list #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amarnus
Copy link

@amarnus amarnus commented Oct 26, 2016

Closes #169

@mention-bot
Copy link

@amarnus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @andruby, @ifuller1 and @vjeux to be potential reviewers.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@vjeux
Copy link
Contributor

vjeux commented Jan 10, 2017

Closing since there hasn't been any update in a while. Please feel free to reopen it if you are making progress, this feature would be great to have :)

@vjeux vjeux closed this Jan 10, 2017
@amarnus
Copy link
Author

amarnus commented Jan 11, 2017

Hey @vjeux, actually I was just waiting for a review.

@shaneog
Copy link
Contributor

shaneog commented May 5, 2017

Pinging @vjeux to review and/or merge 😉

@vjeux vjeux reopened this May 5, 2017
@vjeux
Copy link
Contributor

vjeux commented May 5, 2017

Oops, sorry about it. If you fix the conflicts I'll merge it in. So sorry :(

@tersiasarendse
Copy link

pull request

@dijonkitchen
Copy link

@amarnus want to resolve those merge conflicts?

@gonzalesj1991
Copy link

gonzalesj1991 commented Oct 13, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants