Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

some bugfix #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

some bugfix #29

wants to merge 3 commits into from

Conversation

zqxiaojin
Copy link

fix basename error
fix get die name
fix cplus name demangle
fix dwarf file sholud also search symtab
fix the CI error

Liang Jin added 3 commits March 28, 2015 09:56
2. fix get die name
3. fix cplus name demangle
4. fix dwarf file sholud also search symtab
@zqxiaojin
Copy link
Author

for "fix get die name", I try to search ref die to get the right name of dwarf symbol.

@zqxiaojin
Copy link
Author

use "cplus_demangle_v3(sym, 1 << 0)" instead of "cplus_demangle(sym, 0)" to make some cplus symbol which have namespace to show correct with function params.

@zqxiaojin
Copy link
Author

After you lookup a address at dwarf file and fail to get the symbol, you should try to lookup the address also at symtable . Because the executable file may link to a static library which has been strip debug info.

@zlandau
Copy link
Contributor

zlandau commented Apr 1, 2015

Thanks! In general I think the changes look good, but a few comments before I do a more thorough review:

  1. Can you merge the fixes and style changes into the appropriate commits
  2. having 1-4 listed in a commit message implies that there should really be four separate commits, can you split them up?
  3. it's not entirely clear what all of these bullet points are fixing, so when you split them up can you add a comment explaining the purpose of the change?
  4. Can you show some tests to make sure nothing broken? I know, we should have a better automated suite, but we don't yet :(

@LegNeato
Copy link
Contributor

ping!

@fenss
Copy link

fenss commented Jul 30, 2015

i can play with this code for a whole year!!

@PaniniGelato
Copy link

THIS AMAZING FIX SAVED MY LIFE!

@ghostPM
Copy link

ghostPM commented Jul 30, 2015

zqxiaojin is the core coder whom we are looking for!!

@gmegidish
Copy link

Thank you so much for this patch!

@devholic devholic mentioned this pull request Oct 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
8 participants