Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

fix armv7 bug on linux #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ccarnero
Copy link

@ccarnero ccarnero commented Jun 4, 2014

Hi, I was facing this problem on my linux box:
https://github.com/facebook/atosl/issues/4

So I fixed using the following code (all credit to @hawflakes) and now is working:
https://gist.github.com/hawflakes/9677613

  • I had to update the config.mk file to avoid warnings to be treat as errors

Best regards
Christian

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@zlandau
Copy link
Contributor

zlandau commented Jun 4, 2014

Cool.. I'm not crazy about the hack but I don't have a better solution at the moment. But could you clean up the patch a bit if you want it included? As in, don't just disable -Werror :)

Likely there is just some bug where we aren't properly calculating offsets in a fat binary, but I haven't had time to look into it.

@hawflakes
Copy link

I'm not crazy about the fix, either. But it's been so long since I've looked at DWARF and this got me unstuck.

@LegNeato
Copy link
Contributor

Ping :-)

@zlandau
Copy link
Contributor

zlandau commented Sep 25, 2014

Can you try #18 I think it may fix your issue.

@LegNeato
Copy link
Contributor

Did #18 fix your issue @hawflakes ?

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants