Skip to content
This repository was archived by the owner on Mar 3, 2020. It is now read-only.

Conversation

killerham
Copy link

When sending a test push notification, some of the fields are NSNull instead of nil, causing a crash when trying to access certain content

When sending a test push notification, some of the fields are NSNull instead of nil, causing a crash when trying to access certain content
@facebook-github-bot
Copy link

@killerham I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@killerham
Copy link
Author

@nlutsenko

Copy link
Contributor

@nlutsenko nlutsenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change and we are good to go.

@facebook-github-bot
Copy link

@killerham updated the pull request - view changes

@facebook-github-bot
Copy link

@killerham I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants