Repository navigation
Conversation
The xz block creates ./xz, ./unxz, ./lzma and ./unlzma with `ln -s` and only removes them once the block has passed. The script runs under `set -e`, so a run that fails or is interrupted inside the block leaves the links in tests/, and every later run then aborts with "ln: ./xz: File exists". `make clean` does not remove them. Use `ln -sf`, as the script already does for the zstdcat and zcat links. fix facebook#4431
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4431.
tests/playTests.shcreates./xz,./unxz,./lzmaand./unlzmawithln -sand only removes them at the end of the xz block. The script runs underset -e, so a run that fails or is interrupted inside that block leaves the links intests/, and every later run aborts with:make cleandoes not remove them. This change usesln -sf, as the script already does for thezstdcatandzcatlinks.Testing
make check: forced one command in the xz block to fail, reran, and got the error above.ln -sfreplaces a stale or dangling link the same way.Notes
lz4/unlz4links intests/Makefile. Those are guarded by[ -f lz4 ] ||and did not fail when I tested them with stale links, so I left them unchanged. Happy to add-fthere too if preferred.