Skip to content

Commit

Permalink
minor cleanups in marking partial flows
Browse files Browse the repository at this point in the history
Summary: Wanted to add a log line to indicate forward progress when building the full flow context + saw a commented out line-of-code that we can kill.

Differential Revision: D63260785

fbshipit-source-id: 0e4ed252c8c95544e7f8aa246af412ec29122708
  • Loading branch information
Sinan Cepel authored and facebook-github-bot committed Sep 24, 2024
1 parent 09ed25a commit 6f5d941
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sapp/pipeline/mark_partial_flows.py
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ def _build_candidates_to_transform_from_larger_issue(
for frame in initial_postcondition_frames:
context.add(FrameKey.from_frame(frame))
break
# context.add(FrameKey.from_frame(frame))
# Search preconditions for the transform. If we find the transform here
# for a prefix flow, the initial postcondition frame must be marked instead.
self._build_flow_context_by_searching_graph(
Expand Down Expand Up @@ -291,6 +290,7 @@ def run(self, input: TraceGraph, summary: Summary) -> tuple[TraceGraph, Summary]
context = self._build_full_flow_context(
graph, full_issues, partial_flow_to_mark
)
log.info(f"Built full flow context for {len(full_issues)} issues.")
self._mark_partial_flows(
graph, partial_issues, partial_flow_to_mark.feature, context
)
Expand Down

0 comments on commit 6f5d941

Please sign in to comment.