-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/es modules #307
base: main
Are you sure you want to change the base?
Refactor/es modules #307
Conversation
Could we copy the logic of |
7c3fb57
to
4a0dacc
Compare
@benjamn ive finished working on this, please take a look - aint sure if Please review and let me know if there is anything I need to do to advance it further :) Once this gets merged (and published) I'll try to update most notable projects depending on those packages. |
82cc7a0
to
8c46659
Compare
e4df105
to
498f9a4
Compare
@benjamn rebased against recent master |
…efault, using es modules
498f9a4
to
37df68d
Compare
@benjamn any chances this could get reviewed? 😃 Unfortunately at the moment Im not sure why travis is failing, because locally everything is working fine. It would be great to debug it in ssh mode, but I dont have needed permissions to do it myself. |
37df68d
to
e4e582b
Compare
Hey @benjamn . I know you are extremely busy, I'm just pinging friendly here about this PR :) |
Could this be (rebased and) reviewed? With @babel/polyfill deprecated, there is no (direct) ESM replacement. |
@benjamn is there any chance you or someone from FB would be able to resurrect this? Don't mean to necro or force any work, but was hoping there might be a way to prioritize this especially as this is still under FB's org (and therefore theoretically supported by a very large company). In particular, as #302 (comment) / babel/babel-polyfills#59 point out, this PR would enable a "pure" polyfill. Currently all usage of |
This fixes #302
@benjamn
So Im mostly done when it comes to refactoring
regenerator-runtime
.The missing piece is to change
regenerator-transform
so it adds an import statement to theregenerator-runtime
module. Im not strong with AST (although I know the basics) so an advice how this should be handled would be greatly appreciated! :)Whats the best way to add a single import statement for a file with multiple generators?
How we differentiate what type of import (es/cjs) should be added?
Do we need to support a use case of including the regenerator itself in the outputted bundle? When?