[Flight] Don't block on debug channel if it's not wired up #33757
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
Jul 10, 2025
| @@ -1353,6 +1353,26 @@ function waitForReference<T>( | |||
| map: (response: Response, model: any, parentObject: Object, key: string) => T, | |||
| path: Array<string>, | |||
| ): T { | |||
| if ( | |||
| __DEV__ && | |||
| // TODO: This should check for the existence of the "readable" side, not the "writable". | |||
There was a problem hiding this comment.
We never pass anything into the response when there's a readable. We could maybe add a boolean just for this.
|
Comparing: 56d0dda...129c003 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
unstubbable
approved these changes
Jul 10, 2025
sebmarkbage
force-pushed
the
debugchannel
branch
from
9d9e478 to
129c003
Compare
sebmarkbage
added a commit
to sebmarkbage/react
that referenced
this pull request
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Elements reference debug data (their stack and owner) in the debug channel. If the debug channel isn't wired up this can block the client from resolving.
We can infer that if there's no debug channel wired up and the reference wasn't emitted before the element, then it's probably because it's in the debug channel. So we can skip it.
This should also apply to debug chunks but they're not yet blocking until #33665 lands.