Skip to content

[compiler]: fix link compiler & 4 broken tests from path containing spaces #33409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/apps/playground/scripts/link-compiler.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ set -eo pipefail

HERE=$(pwd)

cd ../../packages/react-compiler-runtime && yarn --silent link && cd $HERE
cd ../../packages/babel-plugin-react-compiler && yarn --silent link && cd $HERE
cd ../../packages/react-compiler-runtime && yarn --silent link && cd "$HERE"
cd ../../packages/babel-plugin-react-compiler && yarn --silent link && cd "$HERE"

yarn --silent link babel-plugin-react-compiler
yarn --silent link react-compiler-runtime
3 changes: 2 additions & 1 deletion packages/internal-test-utils/consoleMock.js
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ function normalizeCodeLocInfo(str) {
// at Component (/path/filename.js:123:45)
// React format:
// in Component (at filename.js:123)
return str.replace(/\n +(?:at|in) ([\S]+)[^\n]*/g, function (m, name) {
return str.replace(/\n +(?:at|in) ([^(\[\n]+)[^\n]*/g, function (m, name) {
name = name.trim();
if (name.endsWith('.render')) {
// Class components will have the `render` method as part of their stack trace.
// We strip that out in our normalization to make it look more like component stacks.
Expand Down
2 changes: 1 addition & 1 deletion scripts/react-compiler/link-compiler.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ fi

HERE=$(pwd)

cd compiler/packages/babel-plugin-react-compiler && yarn --silent link && cd $HERE
cd compiler/packages/babel-plugin-react-compiler && yarn --silent link && cd "$HERE"

yarn --silent link babel-plugin-react-compiler
Loading