chore update electron version in react-devtools to 35.0.0 #32514
+18
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'd like to install the
react-devtools
package as a devDependency instead of running it withnpx
as described in the documentation. Having a newer electron version would solve some security and performance issues as well types incompatibility specific to the project I am working on.How did you test this change?
I only the version and made sure I could run the following:
yarn test-build-devtools
yarn build-for-devtools
Next, run the test shell: