Avoid copying strings when serializing TraceEvent / lock only on buffer operations #52220
+80
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77164969 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jun 25, 2025
…er operations (facebook#52220) Summary: # Changelog: [Internal] Mainly, 2 changes: 1. `PerformanceTracer::serializeTraceEvent(const TraceEvent& event)` -> `PerformanceTracer::serializeTraceEvent(TraceEvent&& event)` for less copies, actually move strings from the `TraceEvent` into the serialized `folly:object`. 2. When collecting events from the buffer, only lock when accessing buffer, not when serializing. Reviewed By: rubennorte Differential Revision: D77164969
hoxyq
force-pushed
the
export-D77164969
branch
2 times, most recently
from
f6ecbf7 to
0efa21d
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jun 25, 2025
…er operations (facebook#52220) Summary: # Changelog: [Internal] Mainly, 2 changes: 1. `PerformanceTracer::serializeTraceEvent(const TraceEvent& event)` -> `PerformanceTracer::serializeTraceEvent(TraceEvent&& event)` for less copies, actually move strings from the `TraceEvent` into the serialized `folly:object`. 2. When collecting events from the buffer, only lock when accessing buffer, not when serializing. Reviewed By: rubennorte Differential Revision: D77164969
|
This pull request was exported from Phabricator. Differential Revision: D77164969 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D77164969 |
|
This pull request was exported from Phabricator. Differential Revision: D77164969 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jun 25, 2025
…er operations (facebook#52220) Summary: Pull Request resolved: facebook#52220 # Changelog: [Internal] Mainly, 2 changes: 1. `PerformanceTracer::serializeTraceEvent(const TraceEvent& event)` -> `PerformanceTracer::serializeTraceEvent(TraceEvent&& event)` for less copies, actually move strings from the `TraceEvent` into the serialized `folly:object`. 2. When collecting events from the buffer, only lock when accessing buffer, not when serializing. Reviewed By: rubennorte Differential Revision: D77164969
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jun 25, 2025
…er operations (facebook#52220) Summary: # Changelog: [Internal] Mainly, 2 changes: 1. `PerformanceTracer::serializeTraceEvent(const TraceEvent& event)` -> `PerformanceTracer::serializeTraceEvent(TraceEvent&& event)` for less copies, actually move strings from the `TraceEvent` into the serialized `folly:object`. 2. When collecting events from the buffer, only lock when accessing buffer, not when serializing. Reviewed By: rubennorte Differential Revision: D77164969
|
This pull request was exported from Phabricator. Differential Revision: D77164969 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D77164969 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jun 25, 2025
…er operations (facebook#52220) Summary: Pull Request resolved: facebook#52220 # Changelog: [Internal] Mainly, 2 changes: 1. `PerformanceTracer::serializeTraceEvent(const TraceEvent& event)` -> `PerformanceTracer::serializeTraceEvent(TraceEvent&& event)` for less copies, actually move strings from the `TraceEvent` into the serialized `folly:object`. 2. When collecting events from the buffer, only lock when accessing buffer, not when serializing. Reviewed By: rubennorte Differential Revision: D77164969
Summary: # Changelog: [Internal] - `bool tracing_` -> `std::atomic<bool> tracingAtomic_`. - More doc-comments to explain the usage of mutex and atomics. - `PerformanceTracer::isTracing()` -> `inline PerformanceTracer::isTracing()`. - `uint64_t processId_` -> `const uint64_t processId_`. The main change is that the boolean flag that controls "if we are tracing" is now atomic, which should eliminate potential data races. To avoid "logic" races, we are still going to lock mutex, and then check again. The use of `std::atomic` allows us to perform cheaper check first to avoid potentially unnecessary serializations from other systems that report events into `PerformanceTracer`. Reviewed By: rubennorte Differential Revision: D77053030
Summary: # Changelog: [Internal] `buffer_.push_back` -> `buffer_.emplace_back` I didn't measure if there were any runtime wins from this, because I don't expect there would be. Let's avoid potential copies, if possible. Reviewed By: rubennorte Differential Revision: D77053032
…2196) Summary: # Changelog: [Internal] Probably been overlooked for quite some time, but shouldn't be a bottleneck. Reviewed By: motiz88 Differential Revision: D77148271
…er operations (facebook#52220) Summary: # Changelog: [Internal] Mainly, 2 changes: 1. `PerformanceTracer::serializeTraceEvent(const TraceEvent& event)` -> `PerformanceTracer::serializeTraceEvent(TraceEvent&& event)` for less copies, actually move strings from the `TraceEvent` into the serialized `folly:object`. 2. When collecting events from the buffer, only lock when accessing buffer, not when serializing. Reviewed By: rubennorte Differential Revision: D77164969
|
This pull request was exported from Phabricator. Differential Revision: D77164969 |
|
This pull request has been merged in ca647c1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Mainly, 2 changes:
PerformanceTracer::serializeTraceEvent(const TraceEvent& event)->PerformanceTracer::serializeTraceEvent(TraceEvent&& event)for less copies, actually move strings from theTraceEventinto the serializedfolly:object.Differential Revision: D77164969