Remove EventPipeConclusion and RuntimeScheduler::callExpiredTasks #52218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [internal] Before the event loop, we had some functionality in the event system to run "expired" tasks after dispatching batched events, providing a functionality similar to microtasks in the Event Loop. After the migration to the Event Loop, we no longer need this mechanism in the new architecture, so we can clean up the related code. This diff does that. IMPORTANT: this assumes there's nothing using `Scheduler` that's not on bridgeless, which we need to validate. Differential Revision: D77155461
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77155461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Before the event loop, we had some functionality in the event system to run "expired" tasks after dispatching batched events, providing a functionality similar to microtasks in the Event Loop. After the migration to the Event Loop, we no longer need this mechanism in the new architecture, so we can clean up the related code.
This diff does that.
IMPORTANT: this assumes there's nothing using
Schedulerthat's not on bridgeless, which we need to validate.Differential Revision: D77155461