Skip to content

Revert "[0.79] Close Sonatype repository during build_android (#52086)" #52089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

cortinico
Copy link
Contributor

Summary:

Taking a more drastic approach. It seems like findSonatypeStagingRepository doesn't work at all. Therefore I'm moving all the publish to happen inside build_npm_package.

See gradle-nexus/publish-plugin#379

Changelog:

[Internal] -

Test Plan:

CI

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
This reverts commit 6e0b1be.
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 17, 2025
@fabriziocucci fabriziocucci merged commit cd422dc into 0.79-stable Jun 17, 2025
76 of 81 checks passed
@fabriziocucci fabriziocucci deleted the nc/079-fix-publishing-take2 branch June 17, 2025 17:04
@szpak
Copy link

szpak commented Jun 17, 2025

It seems like findSonatypeStagingRepository doesn't work at all.

Based on gradle-nexus/publish-plugin#379 (comment), it should work (if the same IP is used). @cortinico Could you comment with the error in that upstream issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants