Define sampling methods implementations for Hermes fallback target delegate #51519
+57
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75188276 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
May 22, 2025
…legate (facebook#51519) Summary: # Changelog: [Internal] Hermes Sampling Profiler doesn't require debugger to be enabled - we can use it in fallback Hermes Runtime target delegate. That's probably the last thing to make Hermes really run in `opt` mode. When Hermes Target is compiled with no Debugger support, we can still define implementation for sampling profiler methods and call them on Hermes Runtime. Differential Revision: D75188276
|
This pull request was exported from Phabricator. Differential Revision: D75188276 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
May 22, 2025
…legate (facebook#51519) Summary: Pull Request resolved: facebook#51519 # Changelog: [Internal] Hermes Sampling Profiler doesn't require debugger to be enabled - we can use it in fallback Hermes Runtime target delegate. That's probably the last thing to make Hermes really run in `opt` mode. When Hermes Target is compiled with no Debugger support, we can still define implementation for sampling profiler methods and call them on Hermes Runtime. Differential Revision: D75188276
hoxyq
force-pushed
the
export-D75188276
branch
2 times, most recently
from
3d4e2cc to
01ad1a3
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
May 22, 2025
…legate (facebook#51519) Summary: # Changelog: [Internal] Hermes Sampling Profiler doesn't require debugger to be enabled - we can use it in fallback Hermes Runtime target delegate. That's probably the last thing to make Hermes really run in `opt` mode. When Hermes Target is compiled with no Debugger support, we can still define implementation for sampling profiler methods and call them on Hermes Runtime. Differential Revision: D75188276
…legate (facebook#51519) Summary: Pull Request resolved: facebook#51519 # Changelog: [Internal] Hermes Sampling Profiler doesn't require debugger to be enabled - we can use it in fallback Hermes Runtime target delegate. That's probably the last thing to make Hermes really run in `opt` mode. When Hermes Target is compiled with no Debugger support, we can still define implementation for sampling profiler methods and call them on Hermes Runtime. Differential Revision: D75188276
|
This pull request was exported from Phabricator. Differential Revision: D75188276 |
|
This pull request has been merged in a633d93. |
|
This pull request was successfully merged by @hoxyq in a633d93 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Hermes Sampling Profiler doesn't require debugger to be enabled - we can use it in fallback Hermes Runtime target delegate. That's probably the last thing to make Hermes really run in
optmode.When Hermes Target is compiled with no Debugger support, we can still define implementation for sampling profiler methods and call them on Hermes Runtime.
Differential Revision: D75188276