RCTTurboModule nits #51499
Closed
RCTTurboModule nits #51499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75141440 |
…ook#51103) Summary: Fixes facebook#51083. Turbo stripped out the dictionary when the value is null. The old architecture transforms null to NSNull. The null seems useful in cases like #51803 for removing the storage of the key. cipolleschi can you please help to review? ## Changelog: [IOS] [FIXED] - Turbo module: Fixes dictionary stripped out when value is null Pull Request resolved: facebook#51103 Test Plan: Repro please see facebook#51083. Differential Revision: D74208525 Pulled By: javache
Summary: Pull Request resolved: facebook#51499 Small nits as follow-up to D74208525 Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D75141440
|
This pull request was exported from Phabricator. Differential Revision: D75141440 |
|
This pull request has been merged in ae4eac1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Small nits as follow-up to D74208525
Changelog: [Internal]
Differential Revision: D75141440