Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust java code example for updating your Application (#4387) #4397

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

adjust java code example for updating your Application (#4387) #4397

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a992c1e
adjust java code example for updating your Application (#4387)
DerBasler Dec 9, 2024
0878be6
adjust java code example for updating your Application (#4387)
DerBasler Dec 12, 2024
84ebed7
Merge branch 'main' into main
DerBasler Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions docs/_integration-with-existing-apps-kotlin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ import android.app.Application;
+import com.facebook.react.defaults.DefaultReactHost;
+import com.facebook.react.defaults.DefaultReactNativeHost;
+import com.facebook.soloader.SoLoader;
+import com.facebook.react.soloader.OpenSourceMergedSoMapping
+import com.facebook.react.soloader.OpenSourceMergedSoMapping;
+import java.util.List;

-class MainApplication extends Application {
Expand Down Expand Up @@ -313,7 +313,11 @@ import android.app.Application;
@Override
public void onCreate() {
super.onCreate();
+ SoLoader.init(this, OpenSourceMergedSoMapping);
+ try {
+ SoLoader.init(this, OpenSourceMergedSoMapping.INSTANCE);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because facebook/react-native#47633 (comment) in my experience it did not work without it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but the IOException catch is not necessary

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree since I catch and just rethrow it, so it is useless but without it the build fails:
error: unreported exception IOException; must be caught or declared to be thrown
SoLoader.init(this, OpenSourceMergedSoMapping.INSTANCE);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. That's a bug inside SoLoader and we should fix it rather than having to tweak the documentation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See:

+ if (BuildConfig.IS_NEW_ARCHITECTURE_ENABLED) {
+ DefaultNewArchitectureEntryPoint.load();
+ }
Expand Down