Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: function names, use getName for adding package. #4368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khushilms
Copy link

@khushilms khushilms commented Nov 23, 2024

This PR contains fixes for the java native modules example files. The fixes include:

  • Accessing the NAME of the NativeLocalStorage from direct access to using a method.
  • Change the method to add the packages from get() to getReactModuleInfos().
  • Add clear() method for the java implementation.

@facebook-github-bot
Copy link

Hi @khushilms!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 437732c
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/6741b855c2ebce0008ca3681
😎 Deploy Preview https://deploy-preview-4368--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khushilms khushilms changed the title FIX: function names, use right functions for java modules FIX: function names, use getName for adding package. Nov 23, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@Abbondanzo Abbondanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the spec implementation above, getName is a method on the module instance but is not available statically. Only the NAME member is accessible statically. This won't compile.

@cortinico
Copy link
Contributor

Closing as per @Abbondanzo 's comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants