Skip to content

Commit

Permalink
fix missing generated tags in fixtures
Browse files Browse the repository at this point in the history
Summary:
For this set of `.py` files, they are generated in non-auto-migrate py3 fixtures missing the `generated` tag. This makes it more annoying to review the diffs and triggers linter.

Fix is easy: always add the `common/auto_generated_py` template regardless of build mode.

Reviewed By: yoney

Differential Revision: D68035822

fbshipit-source-id: 9e8d13400917aaa07ac3990a33f6bbddb8e4255c
  • Loading branch information
ahilger authored and facebook-github-bot committed Jan 11, 2025
1 parent 693eb7f commit e562bd8
Show file tree
Hide file tree
Showing 164 changed files with 964 additions and 164 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ container types, so we'll need to define factories for them based on what they
want to include.
}}
{{#program:auto_migrate?}}
{{> common/auto_generated_py}}
{{#program:auto_migrate?}}
from {{#program:py3Namespaces}}{{value}}.{{/program:py3Namespaces}}{{program:name}}.thrift_clients import *
{{/program:auto_migrate?}}
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ container types, so we'll need to define factories for them based on what they
want to include.
}}
{{#program:auto_migrate?}}
{{> common/auto_generated_py}}
{{#program:auto_migrate?}}
from {{#program:py3Namespaces}}{{value}}.{{/program:py3Namespaces}}{{program:name}}.thrift_metadata import *
{{/program:auto_migrate?}}
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ container types, so we'll need to define factories for them based on what they
want to include.
}}
{{#program:auto_migrate?}}
{{> common/auto_generated_py}}
{{#program:auto_migrate?}}
from {{#program:py3Namespaces}}{{value}}.{{/program:py3Namespaces}}{{program:name}}.thrift_services import *
{{/program:auto_migrate?}}
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ container types, so we'll need to define factories for them based on what they
want to include.
}}
{{#program:auto_migrate?}}
{{> common/auto_generated_py}}
{{#program:auto_migrate?}}
from {{#program:py3Namespaces}}{{value}}.{{/program:py3Namespaces}}{{program:name}}.thrift_types import *
{{#program:hasContainerTypes}}
import thrift.python.types as _fbthrift_python_types
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic-annotations/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic-annotations/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic-annotations/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic-annotations/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic-enum/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic-enum/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic-stack-arguments/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic-stack-arguments/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic-stack-arguments/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic-stack-arguments/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/basic/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/complex-union/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/complex-union/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/constants/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/constants/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/empty-struct/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/empty-struct/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/enums/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/enums/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/exceptions/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/exceptions/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/exceptions/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/exceptions/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for includes.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for includes.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/includes/src/matching_struct_names.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/includes/src/matching_struct_names.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for transitive.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for transitive.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for includes.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for includes.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/includes/src/service.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/includes/src/service.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/includes/src/service.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/includes/src/service.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for transitive.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for transitive.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@

#
# Autogenerated by Thrift for thrift/compiler/test/fixtures/inheritance/src/module.thrift
#
# DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
# @generated
#
Loading

0 comments on commit e562bd8

Please sign in to comment.