Identify profiler suspend reasons #1608
Closed
+77
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The sampling profiler tracks the type of each frame. A "suspend" frame denotes that execution is suspended, with an arbitrary string providing details. We would like to identify GC frames for the sake of Chrome DevTools visualizations/stats about GC time. This diff adds an enum to suspend frames to allow GC frames to be identified without depending on specific contents of the details string. Another option would be to replace the "suspend" frame with multiple different frame types for debugger, GC, etc. Reviewed By: fbmal7 Differential Revision: D68442991
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68442991 |
|
This pull request has been merged in f1d73e5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The sampling profiler tracks the type of each frame. A "suspend" frame
denotes that execution is suspended, with an arbitrary string providing
details.
We would like to identify GC frames for the sake of Chrome DevTools
visualizations/stats about GC time. This diff adds an enum to suspend
frames to allow GC frames to be identified without depending on
specific contents of the details string.
Another option would be to replace the "suspend" frame with multiple
different frame types for debugger, GC, etc.
Reviewed By: fbmal7
Differential Revision: D68442991