Reduce stack depths under Windows clang

Summary: Some tests are currently crashing due to native stack overflows when compiling with clang on Windows. Reduce the depths. Reviewed By: avp Differential Revision: D68568606 fbshipit-source-id: ba21679c1e742c29aa5e265fb0f3f1e3ac895fdf
facebook · Feb 1, 2025 · e877897 · e877897
1 parent ede7def
commit e877897
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/include/hermes/VM/Runtime.h b/include/hermes/VM/Runtime.h
@@ -948,6 +948,8 @@ class HERMES_EMPTY_BASES Runtime : public PointerBase,
       // On windows in dbg mode builds, stack frames are bigger, and a depth
       // limit of 384 results in a C++ stack overflow in testing.
       128
+#elif defined(_MSC_VER) && defined(__clang__) && !defined(NDEBUG)
+      128
 #elif defined(_MSC_VER) && !NDEBUG
       192
 #else

diff --git a/lib/Parser/JSParserImpl.h b/lib/Parser/JSParserImpl.h
@@ -191,6 +191,8 @@ class JSParserImpl {
       128
 #elif defined(_MSC_VER) && defined(HERMES_SLOW_DEBUG)
       128
+#elif defined(_MSC_VER) && defined(__clang__) && !defined(NDEBUG)
+      128
 #elif defined(_MSC_VER)
       512
 #else
-Original file line number
+Diff line change
@@ Expand Up / @@ -191,6 +191,8 @@ class JSParserImpl { @@
     #elif defined(_MSC_VER) && defined(HERMES_SLOW_DEBUG)
+    #elif defined(_MSC_VER) && defined(__clang__) && !defined(NDEBUG)
     #elif defined(_MSC_VER)
     #else
@@ Expand Down @@