Remove return value for _sh_ljs_cache_new_object

Reviewed By: avp Differential Revision: D67105648 fbshipit-source-id: b4908e38553615ffbd36e066f816379374e4c0f2
facebook · Feb 1, 2025 · 7c35ff7 · 7c35ff7
1 parent 2d15713
commit 7c35ff7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/include/hermes/VM/static_h.h b/include/hermes/VM/static_h.h
@@ -801,8 +801,7 @@ SHERMES_EXPORT SHLegacyValue _sh_ljs_new_array_with_buffer(
 /// \p newTarget is the new.target value in the function.
 /// \p shapeTableIndex is the index into the shape table where the serialized
 ///   keys for this operation are stored.
-/// \return \p thisArg.
-SHERMES_EXPORT SHLegacyValue _sh_ljs_cache_new_object(
+SHERMES_EXPORT void _sh_ljs_cache_new_object(
     SHRuntime *shr,
     SHUnit *unit,
     SHLegacyValue *thisArg,

diff --git a/lib/VM/StaticH.cpp b/lib/VM/StaticH.cpp
@@ -1770,14 +1770,12 @@ extern "C" SHLegacyValue _sh_ljs_new_array_with_buffer(
   return arr;
 }
 
-extern "C" SHLegacyValue _sh_ljs_cache_new_object(
+extern "C" void _sh_ljs_cache_new_object(
     SHRuntime *shr,
     SHUnit *unit,
     SHLegacyValue *thisArg,
     SHLegacyValue *newTarget,
-    uint32_t shapeTableIndex) {
-  return *thisArg;
-}
+    uint32_t shapeTableIndex) {}
 
 extern "C" SHLegacyValue _sh_new_fastarray(SHRuntime *shr, uint32_t sizeHint) {
   Runtime &runtime = getRuntime(shr);