Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a function to round image into an ellipse #2456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yithis
Copy link
Contributor

@Yithis Yithis commented Jan 14, 2020

Motivation

#2452

Test Plan

Code was checked by loading different images in showcase app. Best examples are here and here.

@Yithis
Copy link
Contributor Author

Yithis commented Jan 14, 2020

Hope you have access to this link. I'm putting there my next changes, because as far as I know github do not support stacked PR.

@Yithis
Copy link
Contributor Author

Yithis commented Jan 14, 2020

Next changes are here.

Copy link
Contributor

@oprisnik oprisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I'm going to move this to the sample app.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oprisnik has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants