Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance FrescoVitoRegionDecoder #2428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yithis
Copy link
Contributor

@Yithis Yithis commented Oct 29, 2019

Motivation (required)

#2425

Test Plan (required)

./gradlew assembleDebug
Checked with Showcase app fragment for this functionality.

Copy link
Contributor

@oprisnik oprisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oprisnik has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@iadeelzafar iadeelzafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@defHLT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants