Set UI framework for Vito View component

Reviewed By: kartavya-ramnani Differential Revision: D65563999 fbshipit-source-id: d1702d2fd199167b09f16084c62ac11aa8b99e81
facebook · Nov 11, 2024 · b532c53 · b532c53
1 parent 0510267
commit b532c53
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 8 deletions.
diff --git a/vito/view/src/main/java/com/facebook/fresco/vito/view/VitoView.kt b/vito/view/src/main/java/com/facebook/fresco/vito/view/VitoView.kt
@@ -117,9 +117,17 @@ object VitoView {
       imageListener: ImageListener?,
       target: View,
       onFadeListener: OnFadeListener? = null,
+      uiFramework: String = "view",
   ) {
     VitoViewImpl2.show(
-        imageSource, imageOptions, callerContext, imageListener, null, target, onFadeListener)
+        imageSource,
+        imageOptions,
+        callerContext,
+        imageListener,
+        null,
+        target,
+        onFadeListener,
+        uiFramework)
   }
 
   @JvmStatic

diff --git a/vito/view/src/main/java/com/facebook/fresco/vito/view/impl/VitoViewImpl2.kt b/vito/view/src/main/java/com/facebook/fresco/vito/view/impl/VitoViewImpl2.kt
@@ -65,6 +65,7 @@ object VitoViewImpl2 {
       imageRequestListener: VitoImageRequestListener?,
       target: View,
       onFadeListener: OnFadeListener? = null,
+      uiFramework: String = "view",
   ) {
     show(
         FrescoVitoProvider.getImagePipeline()
@@ -79,7 +80,8 @@ object VitoViewImpl2 {
         imageListener,
         imageRequestListener,
         target,
-        onFadeListener)
+        onFadeListener,
+        uiFramework)
   }
 
   @JvmStatic
@@ -91,8 +93,9 @@ object VitoViewImpl2 {
       imageRequestListener: VitoImageRequestListener?,
       target: View,
       onFadeListener: OnFadeListener? = null,
+      uiFramework: String = "view",
   ) {
-    val frescoDrawable = ensureDrawableSet(target)
+    val frescoDrawable = ensureDrawableSet(target, uiFramework)
     // The Drawable might be re-purposed before being cleaned up, so we release if necessary.
     val oldImageRequest = frescoDrawable.imageRequest
     if (oldImageRequest != null && oldImageRequest != imageRequest) {
@@ -154,13 +157,13 @@ object VitoViewImpl2 {
    * @param target the target to use
    * @return The drawable to use for the given target
    */
-  private fun ensureDrawableSet(target: View): FrescoDrawableInterface {
+  private fun ensureDrawableSet(target: View, uiFramework: String): FrescoDrawableInterface {
     return when (target) {
       is ImageView ->
           when (val current = target.drawable) {
             is FrescoDrawableInterface -> current
             else ->
-                createDrawable().also {
+                createDrawable(uiFramework).also {
                   // Force the Drawable to adjust its bounds to match the hosting ImageView's
                   // bounds, since Fresco has custom scale types that are separate from ImageView's
                   // scale type.
@@ -173,7 +176,10 @@ object VitoViewImpl2 {
       else ->
           when (val current = target.background) {
             is FrescoDrawableInterface -> current
-            else -> createDrawable().also { ViewCompat.setBackground(target, it as Drawable) }
+            else ->
+                createDrawable(uiFramework).also {
+                  ViewCompat.setBackground(target, it as Drawable)
+                }
           }
     }
   }
@@ -182,9 +188,9 @@ object VitoViewImpl2 {
     return (if (view is ImageView) view.drawable else view.background) as? FrescoDrawableInterface
   }
 
-  private fun createDrawable(): FrescoDrawableInterface {
+  private fun createDrawable(uiFramework: String): FrescoDrawableInterface {
     val frescoDrawable: FrescoDrawableInterface =
-        FrescoVitoProvider.getController().createDrawable()
+        FrescoVitoProvider.getController().createDrawable(uiFramework)
     if (useVisibilityCallbacks.get()) {
       frescoDrawable.setVisibilityCallback(
           object : VisibilityCallback {