Skip to content

Conversation

@brandonchuang
Copy link
Contributor

@brandonchuang brandonchuang commented Nov 17, 2025

Summary:

This change create sensor_service.json by adding complete
sensor definitions for the MCB/COME/SCM/SMB/BMC,
based on the latest HW_Device_Table and hardware design specifications.
The update includes temperature, voltage, current, and power sensors
with accurate sysfs paths, data types, compute formulas, and threshold values.

The primary purpose of this update is to ensure that FBOSS sensor_service can correctly
enumerate, compute, monitor, and alarm all relevant hardware sensors on the platform.
Additional validation tools (threshold_checker, label_checker, sensors_detect)
are used to confirm correctness and compliance with the hardware specifications.

Test plan:

  1. Run platform_manager to verify that all sensor devices are instantiated successfully.
    w800b_20251117_platform_manager.txt
  2. Start sensor_service and ensure all sensor values can be read without errors.
    w800b_20251125_sensor_service.txt
  3. Execute sensor_service_hw_test and confirm that all test items pass.
    w800b_20251125_sensor_service_hw_test.txt
  4. Run threshold_checker.py to validate that sysfs readings fall within the thresholds defined in sensor_service.json.
    w800b_20251117_sensor_service_threshold_checker_PASSED.txt
  5. Run label_checker.py to ensure each sensor name matches the corresponding _label value read from sysfs.
    w800b_20251117_sensor_service_label_checker_PASSED.txt
  6. Run sensors_detect.py to verify that all expected sensors are detected and created correctly.
    w800b_20251117_sensor_presence_checker_PASSED.txt

@meta-codesync
Copy link

meta-codesync bot commented Nov 20, 2025

@somasun has imported this pull request. If you are a Meta employee, you can view this in D87571633.

Summary:
  This change create sensor_service.json by adding complete sensor definitions for the MCB/COME/SCM/SMB/BMC,
based on the latest HW_Device_Table and hardware design specifications.
The update includes temperature, voltage, current, and power sensors
with accurate sysfs paths, data types, compute formulas, and threshold values.

The primary purpose of this update is to ensure that FBOSS sensor_service can correctly
enumerate, compute, monitor, and alarm all relevant hardware sensors on the platform.
Additional validation tools (threshold_checker, label_checker, sensors_detect)
are used to confirm correctness and compliance with the hardware specifications.

Test plan:
1. Run platform_manager to verify that all sensor devices are instantiated successfully.
   [w800b_20251117_platform_manager.txt](https://github.com/user-attachments/files/23576254/w800b_20251117_platform_manager.txt)
2. Start sensor_service and ensure all sensor values can be read without errors.
   [w800b_20251125_sensor_service.txt](https://github.com/user-attachments/files/23740919/w800b_20251125_sensor_service.txt)
3. Execute sensor_service_hw_test and confirm that all test items pass.
   [w800b_20251125_sensor_service_hw_test.txt](https://github.com/user-attachments/files/23740920/w800b_20251125_sensor_service_hw_test.txt)
4. Run threshold_checker.py to validate that sysfs readings fall within the thresholds defined in sensor_service.json.
   [w800b_20251117_sensor_service_threshold_checker_PASSED.txt](https://github.com/user-attachments/files/23576260/w800b_20251117_sensor_service_threshold_checker_PASSED.txt)
5. Run label_checker.py to ensure each sensor name matches the corresponding _label value read from sysfs.
   [w800b_20251117_sensor_service_label_checker_PASSED.txt](https://github.com/user-attachments/files/23576259/w800b_20251117_sensor_service_label_checker_PASSED.txt)
6. Run sensors_detect.py to verify that all expected sensors are detected and created correctly.
   [w800b_20251117_sensor_presence_checker_PASSED.txt](https://github.com/user-attachments/files/23576255/w800b_20251117_sensor_presence_checker_PASSED.txt)
@facebook-github-bot
Copy link
Contributor

@brandonchuang has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants