New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify videoUploader/VideoEncodingStatusChecker #55

Open

FPG-Alan wants to merge 2 commits into facebook:main from FPG-Alan:m_videoUploader

FPG-Alan commented Jun 27, 2018

Method api.call return a Promise in videoUploader/getStatus, so I add a await before the call to getStatus .

Beside, also add return in ad_video/VideoEncodingStatusChecker so that external call can make a chain operation:

advideo.waitUntilEncodingReady(1000, 10000).then(status => {
    console.log(status)
    ...
})


          modify videoUploader/VideoEncodingStatusChecker

c151ba0

facebook-github-bot added the CLA Signed label


          update

c02b310

Contributor

michaelwclark commented Aug 29, 2018

Both of these changes should be considered for the next release. One is a bug fix, another is an important feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels