Increase SharePhotoContent photos limit to 10 #2469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joesus Is there anything blocking this from being merged? Also, do you happen to know why Apple imposes a limit in the first place? |
|
@ryantobinmeta @yuriy-tolstoguzov Could one of you please have a look at this PR? |
|
Thank you for the pull request! SLComposeViewController indeed ignores anything above 10 photos |
yuriy-tolstoguzov
requested review from
yuriy-tolstoguzov
and removed request for
joesus
yuriy-tolstoguzov
approved these changes
Sep 19, 2024
|
@yuriy-tolstoguzov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@yuriy-tolstoguzov merged this pull request in b07933d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfor bug fixes)Pull Request Details
SLComposeViewControllerhas a limit of 10 images for sharing to Facebook. This PR increases the limit imposed byFBSDKShareKitfrom 6 to 10 and clarifies the comment.Test Plan
Test Plan: Updated the current tests to reflect the change.