Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): Fix build size bot #4248

Merged
merged 2 commits into from
Feb 19, 2021
Merged

chore(v2): Fix build size bot #4248

merged 2 commits into from
Feb 19, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Feb 18, 2021

Motivation

Due to a bug in the GH action, we didn't get appropriate size diffs!

preactjs/compressed-size-action#54

This is a workaround

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Feb 18, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 18, 2021
@netlify
Copy link

netlify bot commented Feb 18, 2021

[V1] Deploy preview success

Built with commit d3c902d

https://deploy-preview-4248--docusaurus-1.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 18, 2021

Size Change: +14 B (0%)

Total Size: 158 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.8 kB 0 B
website/build/assets/js/main.********.js 111 kB +15 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB -2 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.93 kB +1 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 18, 2021

Deploy preview for docusaurus-2 ready!

Built with commit d3c902d

https://deploy-preview-4248--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 18, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4248--docusaurus-2.netlify.app/classic/

@lex111
Copy link
Contributor

lex111 commented Feb 18, 2021

The worst thing about this bot is that it displays only the compressed file sizes. Maybe we should write our own solution.

@slorber
Copy link
Collaborator Author

slorber commented Feb 19, 2021

oh actually just found an undocumented option compression: 'none', let's use that

@slorber slorber merged commit db7a348 into master Feb 19, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/fix-build-size-bot-2 branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants