test env: include LOCALE_ARCHIVE - #1468
Open
lf- wants to merge 1 commit into
Open
Conversation
The reason we need this is that nix doesn't hardcode the location of the glibc locales and use it as an impure dependency. Which thus means that we need to be able to wrap it into our buck2 itself, so that we have fully hermetic glibc locales on Linux. The upshot of this is that we need to add it to the list of env vars that go into tests.
meta-cla
Bot
added
the
CLA Signed
lf-
added a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Aug 18, 2026
The reason we need this is that nix doesn't hardcode the location of the glibc locales and use it as an impure dependency. Which thus means that we need to be able to wrap it into our buck2 itself, so that we have fully hermetic glibc locales on Linux. The upshot of this is that we need to add it to the list of env vars that go into tests. Upstream PR: facebook#1468
lf-
added a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Aug 18, 2026
The reason we need this is that nix doesn't hardcode the location of the glibc locales and use it as an impure dependency. Which thus means that we need to be able to wrap it into our buck2 itself, so that we have fully hermetic glibc locales on Linux. The upshot of this is that we need to add it to the list of env vars that go into tests. Upstream PR: facebook#1468
This was referenced Aug 18, 2026
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D116497324. (Because this pull request was imported automatically, there will not be any future comments.) |
lf-
added a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Aug 18, 2026
The reason we need this is that nix doesn't hardcode the location of the glibc locales and use it as an impure dependency. Which thus means that we need to be able to wrap it into our buck2 itself, so that we have fully hermetic glibc locales on Linux. The upshot of this is that we need to add it to the list of env vars that go into tests. Upstream PR: facebook#1468
lf-
added a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Aug 18, 2026
The reason we need this is that nix doesn't hardcode the location of the glibc locales and use it as an impure dependency. Which thus means that we need to be able to wrap it into our buck2 itself, so that we have fully hermetic glibc locales on Linux. The upshot of this is that we need to add it to the list of env vars that go into tests. Upstream PR: facebook#1468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason we need this is that nix doesn't hardcode the location of the glibc locales and use it as an impure dependency. Which thus means that we need to be able to wrap it into our buck2 itself, so that we have fully hermetic glibc locales on Linux.
The upshot of this is that we need to add it to the list of env vars that go into tests.