Support body on delete requests #226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Open to fixing this, but won't be back from vacation until next week. If you want it urgently, please update one of the test cases with example openapi spec for this and generated code |
aderington
reviewed
Feb 25, 2025
| "toMediaType".toClassName("okhttp3.MediaType.Companion") | ||
| ) | ||
| } ?: this.add("\n.%N(ByteArray(0).%T())", verb, toRequestBody) | ||
| } ?: if (verb == "delete") this.add("\n.delete()") else this.add("\n.%N(ByteArray(0).%T())", verb, toRequestBody) |
There was a problem hiding this comment.
This change seems out of place. I suggest checking to see if a delete verb has any Body parameters in addRequestStatement.
| "HEAD" -> this.add("\n.head()") | ||
| "GET" -> this.add("\n.get()") | ||
| "DELETE" -> this.add("\n.delete()") | ||
| "DELETE" -> this.addRequestSerializerStatement("delete") |
There was a problem hiding this comment.
I haven't cloned the repo yet, but on first light, I think something like this would be a more cohesive solution.
"DELETE" -> {
val hasBodyParameters = parameters.any { it is BodyParameter }
if (hasBodyParameters) {
this.addRequestSerializerStatement("delete")
} else {
this.add("\n.delete()")
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #225