Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Search by parent #2275

Merged
merged 7 commits into from
Sep 6, 2018
Merged

Search by parent #2275

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d69834
Started to implement search by parent
kwk Sep 5, 2018
6ccfd54
Merge remote-tracking branch 'upstream/master' into search-by-parent
kwk Sep 5, 2018
4046f24
Make execution order not ambigious when parent table (work_items) is …
kwk Sep 5, 2018
1308770
Fix tests and parent / parent_link table join
kwk Sep 5, 2018
8045dea
Add comment
kwk Sep 5, 2018
284f462
Fix comment
kwk Sep 6, 2018
6000fdb
Add comma in comment
kwk Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions workitem/table_join.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ type TableJoin struct {
// object to be activated.
PrefixActivators []string // e.g. []string{"iteration."}

// disallowedColumns specified all fields that are allowed to be queried
// from the foreign table. When empty all columns are allowed.
// AllowedColumns specified all fields that are allowed to be queried from
// the foreign table. When empty all columns are allowed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comma, please, after the empty?
Like When empty, all columns are allowed. I couldn't understand the sentence at first. :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 6000fdb

AllowedColumns []string // e.g. ["name"].

// DisallowedColumns specified all fields that are not allowed to be queried
Expand Down