This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Provide join lock down #2211
Merged
Provide join lock down #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alien-ike
changed the title
alien-ike
changed the title
alien-ike
changed the title
Ike Plugins (test-keeper)Thank you @kwk for this contribution!
It appears that no tests have been added or updated in this PR. Automated tests give us confidence in shipping reliable software. Please add some as part of this change. If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command For more information please head over to official documentation. You can find there how to configure the plugin. |
kwk
changed the title
alien-ike
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2211 +/- ##
==========================================
+ Coverage 69.77% 69.99% +0.22%
==========================================
Files 170 170
Lines 15846 15913 +67
==========================================
+ Hits 11057 11139 +82
+ Misses 3778 3761 -17
- Partials 1011 1013 +2
Continue to review full report at Codecov.
|
kwk
changed the title
kwk
changed the title
kwk
changed the title
4 tasks
kwk
changed the title
aslakknutsen
approved these changes
Aug 7, 2018
|
/ok-without-tests |
kwk
added a commit
to openshiftio/saas-openshiftio
that referenced
this pull request
Aug 7, 2018
commit fabric8-services/fabric8-wit@2661cf8 Author: Konrad Kleine <[email protected]> Date: Tue Aug 7 15:40:55 2018 +0200 Provide join lock down (fabric8-services/fabric8-wit#2211) This includes an extra-condition in the `ON` part of the table `JOINS` for areas, codebases and iterations to only join those tables filtered by their space ID. I'm not sure though if this really fixes the problem (see fabric8-services/fabric8-wit#2210 (comment)). ## TODO As of yesterday's (07.08.2018) discussion with @aslakknutsen we did experiments and found that in order to keep the rows in the search small, we have to establish a condition on the final SQL `WHERE` clause that limits the selection to work items from a particular space. At the moment, the current `/api/search` endpoint is so generic that it doesn't require a limitation by space on the root of the `WHERE` clause. That's why @aslakknutsen and I agreed to create a search endpoint under `/api/spaces/<SPACE-UUID>/search` in order to automatically add the space ID to the query condition. This will be implemented in another PR and is tracked in openshiftio/openshift.io#4124 See fabric8-services/fabric8-wit#2210.
aslakknutsen
pushed a commit
to openshiftio/saas-openshiftio
that referenced
this pull request
Aug 7, 2018
commit fabric8-services/fabric8-wit@2661cf8 Author: Konrad Kleine <[email protected]> Date: Tue Aug 7 15:40:55 2018 +0200 Provide join lock down (fabric8-services/fabric8-wit#2211) This includes an extra-condition in the `ON` part of the table `JOINS` for areas, codebases and iterations to only join those tables filtered by their space ID. I'm not sure though if this really fixes the problem (see fabric8-services/fabric8-wit#2210 (comment)). ## TODO As of yesterday's (07.08.2018) discussion with @aslakknutsen we did experiments and found that in order to keep the rows in the search small, we have to establish a condition on the final SQL `WHERE` clause that limits the selection to work items from a particular space. At the moment, the current `/api/search` endpoint is so generic that it doesn't require a limitation by space on the root of the `WHERE` clause. That's why @aslakknutsen and I agreed to create a search endpoint under `/api/spaces/<SPACE-UUID>/search` in order to automatically add the space ID to the query condition. This will be implemented in another PR and is tracked in openshiftio/openshift.io#4124 See fabric8-services/fabric8-wit#2210.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes an extra-condition in the
ONpart of the tableJOINSfor areas, codebases and iterations to only join those tables filtered by their space ID. I'm not sure though if this really fixes the problem (see #2210 (comment)).TODO
As of yesterday's (07.08.2018) discussion with @aslakknutsen we did experiments and found that in order to keep the rows in the search small, we have to establish a condition on the final SQL
WHEREclause that limits the selection to work items from a particular space. At the moment, the current/api/searchendpoint is so generic that it doesn't require a limitation by space on the root of theWHEREclause. That's why @aslakknutsen and I agreed to create a search endpoint under/api/spaces/<SPACE-UUID>/searchin order to automatically add the space ID to the query condition.This will be implemented in another PR and is tracked in openshiftio/openshift.io#4124
See #2210.