Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

WIP: Improve test data #2160

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Improve test data #2160

wants to merge 2 commits into from

Conversation

kwk
Copy link
Collaborator

@kwk kwk commented Jul 11, 2018 •
edited
Loading

I'm working on this PR to change the test data layout.... will write more about it soon.

@kwk kwk self-assigned this Jul 11, 2018
@kwk kwk changed the title WIP: Default for simple type WIP: Default Value for WI fields of type simple, list, enum Jul 11, 2018
@codecov-io
Copy link

codecov-io commented Jul 11, 2018 •
edited
Loading

Codecov Report

Merging #2160 into master will increase coverage by 0.05%.
The diff coverage is 63.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2160      +/-   ##
==========================================
+ Coverage   69.35%   69.41%   +0.05%     
==========================================
  Files         170      166       -4     
  Lines       15995    15504     -491     
==========================================
- Hits        11094    10762     -332     
+ Misses       3855     3766      -89     
+ Partials     1046      976      -70
Impacted Files Coverage Δ
workitem/field_definition.go 81.3% <100%> (+0.6%) ⬆️
workitem/list_type.go 88.57% <33.33%> (-11.43%) ⬇️
workitem/simple_type.go 79.43% <42.85%> (-1.44%) ⬇️
controller/workitemtype.go 66.17% <45.71%> (-9.28%) ⬇️
workitem/enum_type.go 85.36% <81.81%> (-8.26%) ⬇️
spacetemplate/importer/repository.go 78.92% <94.73%> (+7.27%) ⬆️
rendering/markdown.go 63.15% <0%> (-13.16%) ⬇️
workitem/link/type.go 92.45% <0%> (-7.55%) ⬇️
ptr/ptr.go 23.52% <0%> (-5.89%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b688f8f...2c142a8. Read the comment docs.

@kwk kwk changed the title WIP: Default Value for WI fields of type simple, list, enum Default Value for WI fields of type simple, list, enum Jul 12, 2018
@kwk kwk changed the title Default Value for WI fields of type simple, list, enum WIP: Default Value for WI fields of type simple, list, enum Jul 12, 2018
@kwk
Copy link
Collaborator Author

kwk commented Jul 18, 2018

[test]

@DhritiShikhar DhritiShikhar mentioned this pull request Jul 26, 2018
Closed
@kwk kwk mentioned this pull request Jul 27, 2018
Closed
tinakurian
tinakurian previously approved these changes Jul 27, 2018
View reviewed changes
@kwk kwk force-pushed the default_for_simple_type branch from 0b33f55 to 2c142a8 Compare August 20, 2018 09:45
@kwk kwk changed the title WIP: Default Value for WI fields of type simple, list, enum WIP: Improve test data Aug 20, 2018
@kwk kwk dismissed stale reviews from tinakurian and michaelkleinhenz August 20, 2018 09:54

This PR is not ready.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinakurian tinakurian tinakurian left review comments

@michaelkleinhenz michaelkleinhenz michaelkleinhenz left review comments

@jarifibrahim jarifibrahim Awaiting requested review from jarifibrahim

@baijum baijum Awaiting requested review from baijum

@DhritiShikhar DhritiShikhar Awaiting requested review from DhritiShikhar

At least 1 approving review is required to merge this pull request.

Assignees

@kwk kwk

Labels
💣 test database enhancement jsonapi ♻️ refactoring space_templates work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kwk @codecov-io @michaelkleinhenz @tinakurian @alien-ike