Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set typed = true when the wrapped schema of nonOptional is typed #926

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Set typed = true when the wrapped schema of nonOptional is typed #926

merged 2 commits into from
Nov 15, 2024
+14 −8

Conversation

genki
Copy link
Contributor

@genki genki commented Nov 15, 2024

This fixes #925

The nonOptional schema has not been typed = true when its wrapping schema becomes typed = true.
I did changed it to be typed.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 15, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/valibot@926

commit: 5288f7a

@fabian-hiller fabian-hiller self-assigned this Nov 15, 2024
@fabian-hiller fabian-hiller added the fix A smaller enhancement or bug fix label Nov 15, 2024
@fabian-hiller fabian-hiller merged commit f6c2ebc into fabian-hiller:main Nov 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabian-hiller fabian-hiller

Labels
fix A smaller enhancement or bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The union schema of schemas containing a object schema that requires an union schema causes unexpected error.
2 participants
@genki @fabian-hiller