Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement code points validator #888

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tats-u
Copy link

@tats-u tats-u commented Oct 20, 2024

Fixes #875

Implemented based on graphemes validation.

@fabian-hiller fabian-hiller self-assigned this Oct 20, 2024
@fabian-hiller fabian-hiller added the enhancement New feature or request label Oct 20, 2024
@fabian-hiller
Copy link
Owner

Thank you for creating this PR! I will try to review and merge it in the next weeks. 🙏

@tats-u
Copy link
Author

tats-u commented Oct 22, 2024

I might export the implementation of _getCodePointCoun to other validators (e.g. Zod) in the future.

@fabian-hiller
Copy link
Owner

I just want to let you know that I am focusing on our v1 release first before reviewing this PR.

@tats-u
Copy link
Author

tats-u commented Oct 28, 2024

That's not good news. I'll wait for v1.1.0.
And I want to get permission to publish _getCodePointCount as my independent package from you.
If that function is improved by others, I'll try to get permission from them or keep mine as is.

@fabian-hiller
Copy link
Owner

Yes, feel free to create your own package. No permission required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maxCodePoints / minCodePoints (UTF-32 code points)
2 participants