-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add f5_passwordpolicy type/provider #14
base: master
Are you sure you want to change the base?
Conversation
Puppet::Type.newtype(:f5_passwordpolicy) do | ||
@doc = 'Sets the password policy on the BIG-IP system.' | ||
|
||
apply_to_device if Facter.value(:url).nil? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The if Facter.value(:url).nil?
makes it possible to use puppet resource
or puppet apply
to set properties. This is really helpful during testing! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 @alexjfisher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance you can provide acceptance tests as well @alexjfisher ? We are updating the README to indicate additional types and providers should come with passing acceptance tests. Thank you.
@abrader I would like to add acceptance tests, but I'm not sure I'm able to run them locally. It looks like they're setup to use Puppet Inc's vmpooler testing infrastructure and/or AWS? If they were automatically run by travis that'd be really helpful. |
219562a
to
28adb2c
Compare
I've added a really simple acceptance test. It should work, but I've not got an AWS F5 test environment, so I haven't actually run it! |
No description provided.