Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add f5_passwordpolicy type/provider #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexjfisher
Copy link
Contributor

No description provided.

Puppet::Type.newtype(:f5_passwordpolicy) do
@doc = 'Sets the password policy on the BIG-IP system.'

apply_to_device if Facter.value(:url).nil?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if Facter.value(:url).nil? makes it possible to use puppet resource or puppet apply to set properties. This is really helpful during testing! :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@abrader abrader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you can provide acceptance tests as well @alexjfisher ? We are updating the README to indicate additional types and providers should come with passing acceptance tests. Thank you.

@alexjfisher
Copy link
Contributor Author

@abrader I would like to add acceptance tests, but I'm not sure I'm able to run them locally. It looks like they're setup to use Puppet Inc's vmpooler testing infrastructure and/or AWS? If they were automatically run by travis that'd be really helpful.

@alexjfisher
Copy link
Contributor Author

I've added a really simple acceptance test. It should work, but I've not got an AWS F5 test environment, so I haven't actually run it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants